Skip to content

Fix aria-label interpolation and missing "opens in new tab" on external links#548

Merged
MaanavD merged 2 commits intowebsite-cleanup-and-a11yfrom
copilot/sub-pr-547
Mar 24, 2026
Merged

Fix aria-label interpolation and missing "opens in new tab" on external links#548
MaanavD merged 2 commits intowebsite-cleanup-and-a11yfrom
copilot/sub-pr-547

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

Svelte does not interpolate {expr} inside quoted attribute strings — they are treated as literals. Four aria-label attributes were broken in this way, and one external-link label was missing the "opens in new tab" annotation required for WCAG consistency.

Changes

  • ModelDetailsModal.svelte / ModelCard.svelte: Change aria-label="{model.license} ..."aria-label={...${model.license}...} so the actual license value reaches assistive tech instead of the literal string {model.license}.
  • social-media.svelte: Same fix for {title}aria-label="{title} (opens in new tab)"aria-label={${title} (opens in new tab)}.
  • download-dropdown.svelte: Add (opens in new tab) to the GitHub Releases link aria-label, consistent with all other target="_blank" links in the codebase.
<!-- Before: Svelte treats {model.license} as a literal string -->
aria-label="{model.license} license (opens in new tab)"

<!-- After: properly interpolated -->
aria-label={`${model.license} license (opens in new tab)`}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Mar 24, 2026 1:59am

Request Review

Copilot AI changed the title [WIP] Cleanup website: remove docs, cookies, accessibility fixes and package upgrades Fix aria-label interpolation and missing "opens in new tab" on external links Mar 24, 2026
Copilot AI requested a review from MaanavD March 24, 2026 01:59
@MaanavD MaanavD marked this pull request as ready for review March 24, 2026 02:00
@MaanavD MaanavD merged commit 5228025 into website-cleanup-and-a11y Mar 24, 2026
3 checks passed
@MaanavD MaanavD deleted the copilot/sub-pr-547 branch March 24, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants