Merged
Conversation
## Summary Fixes an incorrect informational log message in the C# SDK's web unload path. ## Changes - Updated `WebUnloadModelAsync` in `sdk/cs/src/Detail/ModelLoadManager.cs` - Changed the success log text from "loaded successfully" to "unloaded successfully" ## Why Consumers of `sdk/cs` provide their own `ILogger`, so this message is surfaced in their application logs. The old text was misleading and could cause confusion during debugging and support investigations.
Change the public download progress callback type from FnMut(&str) to FnMut(f64) for cross-SDK consistency. Python, JS, and C# SDKs all expose a numeric float type for download progress. The string-to-float parsing now happens inside model_variant.rs (using chunk.parse::<f64>()), matching the pattern already used by download_and_register_eps_with_progress. Unparseable chunks are silently TryParse). The internal core_interop streaming infrastructure remains unchanged since it is shared with chat/audio streaming. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
baijumeswani
force-pushed
the
baijumeswani/cherry-pick-5
branch
from
affde2e to
6cd5411
Compare
prathikr
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.