fixes netstandard2.0 bug in embeddings request response types#675
Merged
fixes netstandard2.0 bug in embeddings request response types#675
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
baijumeswani
previously approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a nullable flow-analysis warning under netstandard2.0 by ensuring response.Data is treated as non-null after an existing guard.
Changes:
- Added a null-forgiving operator (
!) when passingresponse.DataintoToEmbeddingResponse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phanindraraja
previously approved these changes
Apr 24, 2026
d4b7d58
baijumeswani
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The null check string.IsNullOrWhiteSpace doesn't narrow the nullable type under netstandard2.0's annotations. Needs to be response.Data! to avoid error but we know it's not null or whitespace due to the check above.