Fix DLL load failure on Windows for paths containing non-ANSI characters#743
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-specific DLL loading failure in the JS SDK’s native N-API add-on when library paths contain characters outside the active ANSI code page, by routing Windows loads through LoadLibraryW using UTF-16 paths sourced from N-API.
Changes:
- Introduces
open_lib_from_napi()to load libraries from N-API string values, usingLoadLibraryWon Windows anddlopenon POSIX. - Updates
loadLibrary(corePath, depPaths?)to use the new helper for dependency and core library loading. - Removes the
LoadLibraryA-basedLIB_OPENmacro usage and documents the rationale.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bmehta001
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS SDK's native add-on fails to load onnxruntime.dll (and other dependency libraries) when the path contains characters outside the active Windows ANSI code page. Customers running the SDK from a profile directory with non-ascii characters see:
sdk/js/native/foundry_local_napi.cusedLoadLibraryA, which interprets the path bytes as the active ANSI code page. N-API hands us a lossless UTF-8 string, butLoadLibraryAthen mis-decodes those bytes and the loader returnsERROR_MOD_NOT_FOUND.This pull-request routesWindows library loads through LoadLibraryW with a UTF-16 path fetched via napi_get_value_string_utf16. POSIX behaviour is unchanged (dlopen is already UTF-8).