Skip to content

Bugfix: Fix the bug of screen recorder not stopped when task is canceled#489

Merged
taoran6 merged 2 commits intomainfrom
taoran/cancel_fix
Jun 6, 2023
Merged

Bugfix: Fix the bug of screen recorder not stopped when task is canceled#489
taoran6 merged 2 commits intomainfrom
taoran/cancel_fix

Conversation

@taoran6
Copy link
Contributor

@taoran6 taoran6 commented Jun 5, 2023

Linked GitHub issue ID: #

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

olivershen-wow
olivershen-wow previously approved these changes Jun 6, 2023
@taoran6 taoran6 enabled auto-merge (squash) June 6, 2023 08:37
@taoran6 taoran6 merged commit d8d3a68 into main Jun 6, 2023
@taoran6 taoran6 deleted the taoran/cancel_fix branch June 6, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants