[R-package] [python-package] deprecate Dataset arguments to cv() and train() #6446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6435.
Adds deprecation warnings for all the cases mentioned in #6435, and some other changes that flow from that:
categorical_feature
andcolnames
to top-level arguments oflightgbm()
in the R packagelgb.train()
's support for setting those on theDataset
Notes for Reviewers
I'd like to get these warnings out in the v4.4.0 release (#6439), and then leave them there for at least 2 more releases.
copying some others who may be interested: @mayer79 @david-cortes @simonpcouch
How I tested this
Ran the R tests and Python tests, and checked for these warnings.
Interactively ran some code in both languages and confirmed that the expected warnings were raised.