Resolve the problem with conv weights#183
Merged
edwardjhu merged 1 commit intomicrosoft:mainfrom Dec 17, 2024
fardinayar:main
Merged
Resolve the problem with conv weights#183edwardjhu merged 1 commit intomicrosoft:mainfrom fardinayar:main
edwardjhu merged 1 commit intomicrosoft:mainfrom
fardinayar:main
Conversation
emi-dm
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I tested it and it works fine @edwardjhu The problem is related to the load_state_dict method, which doesn't match the "weight" key in the convolutional modules
Phamduy1247
approved these changes
Dec 17, 2024
Phamduy1247
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for sharing loralib!
Regarding the issue with loading pretrained conv layers, I think that this little modification will solve the problem.