Skip to content

Include MS.VS.OLE.Interop.dll for XPLAT#1061

Merged
WardenGnaw merged 1 commit intomainfrom
dev/waan/fixMSFTOLEDrop
Oct 20, 2020
Merged

Include MS.VS.OLE.Interop.dll for XPLAT#1061
WardenGnaw merged 1 commit intomainfrom
dev/waan/fixMSFTOLEDrop

Conversation

@WardenGnaw
Copy link
Member

We also need Microsoft.VisualStudio.OLE.Interop.dll for VS Code since it will be sending ModuleEvents and parsing FILETIME.

@gregg-miskelly
Copy link
Member

gregg-miskelly commented Oct 20, 2020

I don't understand why we are dropping any of these files in non-XPlat. Do you know? Ex, I would thought it should be:

  <ItemGroup>
    <DropSignedFile Include="$(OutputPath)\OpenDebugAD7.exe" />
    <DropUnsignedFile Include="$(OutputPath)\OpenDebugAD7.exe.config" />
    <DropUnsignedFile Include="$(OutputPath)\Newtonsoft.Json.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Shared.VSCodeDebugProtocol.dll" />
    <DropUnsignedFile Include="$(OutputPath)\cppdbg.ad7Engine.json" />
  </ItemGroup>
  <ItemGroup Condition="'$(IsXPlat)' == 'true'">
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.OLE.Interop.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.InteropA.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.10.0.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.11.0.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.12.0.dll" />
    <DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.15.0.dll" />
    <DropUnsignedFile Include="$(OutputPath)\OpenDebugAD7.exe.mdb" />
  </ItemGroup>

@WardenGnaw
Copy link
Member Author

I thought that it was dropped for <VS_ROOT>\Common7\IDE\CommonExtensions\Microsoft\MDD\Debugger\vscode.
The VS -> VSCodeDebugAdapterHost -> OpenDebugAD7.exe

@gregg-miskelly
Copy link
Member

Got it. We should probably fix App.VS.config to reference these files from PrivateAssemblies (or add a AssemblyResolve hook for that) so we don't need to drop a bunch of extra copies of dlls that VS will already drop. But no need to fix this now I supposed.

@WardenGnaw
Copy link
Member Author

Tracking Fixing App.VS.config in #1062

@WardenGnaw WardenGnaw merged commit 097985e into main Oct 20, 2020
WardenGnaw added a commit that referenced this pull request Oct 20, 2020
Merge 'main' into 'release-cpptools' (#1061)
@WardenGnaw WardenGnaw deleted the dev/waan/fixMSFTOLEDrop branch September 21, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants