Include MS.VS.OLE.Interop.dll for XPLAT#1061
Merged
WardenGnaw merged 1 commit intomainfrom Oct 20, 2020
Merged
Conversation
Member
|
I don't understand why we are dropping any of these files in non-XPlat. Do you know? Ex, I would thought it should be: <ItemGroup>
<DropSignedFile Include="$(OutputPath)\OpenDebugAD7.exe" />
<DropUnsignedFile Include="$(OutputPath)\OpenDebugAD7.exe.config" />
<DropUnsignedFile Include="$(OutputPath)\Newtonsoft.Json.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Shared.VSCodeDebugProtocol.dll" />
<DropUnsignedFile Include="$(OutputPath)\cppdbg.ad7Engine.json" />
</ItemGroup>
<ItemGroup Condition="'$(IsXPlat)' == 'true'">
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.OLE.Interop.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.InteropA.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.10.0.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.11.0.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.12.0.dll" />
<DropUnsignedFile Include="$(OutputPath)\Microsoft.VisualStudio.Debugger.Interop.15.0.dll" />
<DropUnsignedFile Include="$(OutputPath)\OpenDebugAD7.exe.mdb" />
</ItemGroup> |
Member
Author
|
I thought that it was dropped for |
Member
|
Got it. We should probably fix App.VS.config to reference these files from PrivateAssemblies (or add a AssemblyResolve hook for that) so we don't need to drop a bunch of extra copies of dlls that VS will already drop. But no need to fix this now I supposed. |
gregg-miskelly
approved these changes
Oct 20, 2020
Member
Author
|
Tracking Fixing App.VS.config in #1062 |
WardenGnaw
added a commit
that referenced
this pull request
Oct 20, 2020
Merge 'main' into 'release-cpptools' (#1061)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also need Microsoft.VisualStudio.OLE.Interop.dll for VS Code since it will be sending ModuleEvents and parsing FILETIME.