Merge 'main' into 'release_mdd'#1222
Merged
WardenGnaw merged 11 commits intorelease_mddfrom Sep 17, 2021
Merged
Conversation
* Fix LogPoint Issue Customer reported in v1.6.0 that LogPoints stopped working. This was due to IDebugBreakpointEvent2.EnumBreakpoints returning the same IEnumDebugBoundBreakpoints2. The fix was to save IDebugBoundBreakpoint2[] in the event and return a new IEnumDebugBoundBreakpoints2 object per call. Added a test for logpoints and fixed up ConsoleEvent to be OutputEvent since thats what it should actually be. Added flag IgnoreResponseOrder to allow looking at historical responses to find out if the expected response occurred before.
* Normalize Building MIEngine for VS/VSCode This PR adds ./eng/Scripts that can be used to build MIDebugEngine / MIDebugEngine-Unix on Windows/macOS/Linux similar to how the CI does it. CI-Test.[cmd|ps1] is not added because setup is a bit more complicated than linux/macOS.
* Fix PlatformUtilities methods Use 'RuntimeInformation.IsOSPlatform' instead of 'Environment.OSVersion.Platform' Environment.OSVersion.Platform on .NET 5 is returning 'Unix' for macOS which is causing a bunch of our cases to not work. Tested RuntimeInformation.IsOSPlatform(OSPlatform.Windows) on net472 on Windows and it returns true. * Disable EnvironmentTest w/ spaces darwin-debug does not like environment with spaces, and it is sent by lldb-mi. Needs to be fixed externally. * Disable more tests
* Move to 1ES pools
* Add support for debugging macOS app bundles This PR adds support for debugging app bundles on macOS. LLDB understands how to handle app bundles when provided to -file-exec-and-symbols. Reference: ./lldb-mi (gdb) -file-exec-and-symbols /Applications/VLC.app ^done (gdb) =library-loaded,id="/Applications/VLC.app/Contents/MacOS/VLC",target-name="/Applications/VLC.app/Contents/MacOS/VLC",host-name="/Applications/VLC.app/Contents/MacOS/VLC",symbols-loaded="0",loaded_addr="-",size="20480" * Add macOS App Test Add XCodeBuild Compiler Add support for running tests Missing actual test Move to correct location * Address PR issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.