Merge 'main' into 'release_mdd'#1379
Merged
WardenGnaw merged 2 commits intorelease_mddfrom Dec 2, 2022
Merged
Conversation
* Fix race on stopping monitor This PR fixes the race condition when disposing of the RegistryMonitor and when detecting the stop. This PR modifies Dispose to call Stop() which will cause the wait handler to fire and stop the Monitor thread which will properly dispose of the object.
This PR fixes the variable used for the RegistryMonitor on a fresh VS instance. If the private registry does not have a NatvisDiagnostic section, it will watch for its creation then delete this watcher. However when creating the new watcher it would watch on a null section instead of the new natvis section. This PR fixes that issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.