Pass global config to Service constructor#435
Merged
Conversation
bpkroth
reviewed
Jul 5, 2023
bpkroth
reviewed
Jul 5, 2023
Contributor
|
I think merging #438 should fix the build issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, it is not enough to substitute the top-level Service config parameters with the globals - sometimes the placeholders are not at the top level (e.g.,
deploymentTemplateParametersofAzureVMService) so we need to pass theglobal_configexplicitly into each Service constructor.This update allows us to collect all configurable parameters from all services and environments in a single config