Skip to content

Fix evaluate issue #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lokijota merged 5 commits into from
Dec 14, 2021
Merged

Fix evaluate issue #381

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e0b40f
update documentation
Oct 25, 2021
391d446
fix evaluate issue
Oct 27, 2021
432c4b9
linting
Oct 27, 2021
d886881
Merge branch 'master' into fix_evaluate_issue
lokijota Dec 14, 2021
bd4a169
Merge branch 'master' into fix_evaluate_issue
lokijota Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions diabetes_regression/evaluate/evaluate_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,21 @@
production_model_mse = 10000
if (metric_eval in model.tags):
production_model_mse = float(model.tags[metric_eval])
new_model_mse = float(run.parent.get_metrics().get(metric_eval))
try:
new_model_mse = float(run.parent.get_metrics().get(metric_eval))
except TypeError:
new_model_mse = None
if (production_model_mse is None or new_model_mse is None):
print("Unable to find", metric_eval, "metrics, "
print("Unable to find ", metric_eval, " metrics, "
"exiting evaluation")
if((allow_run_cancel).lower() == 'true'):
run.parent.cancel()
else:
print(
"Current Production model mse: {}, "
"New trained model mse: {}".format(
production_model_mse, new_model_mse
"Current Production model {}: {}, ".format(
metric_eval, production_model_mse) +
"New trained model {}: {}".format(
metric_eval, new_model_mse
)
)

Expand Down