Merged
Conversation
Member
|
We'll want to check the produced NuGet packages and make sure the dependencies are declared appropriately. Reminder: the "Common" package should have some deps, the implementation packages should not have any. |
Collaborator
Author
|
|
johnterickson
force-pushed
the
ilrepack
branch
from
69eb933 to
8d2f996
Compare
johnterickson
commented
Jan 30, 2024
johnterickson
force-pushed
the
ilrepack
branch
from
d28ffa5 to
69eb933
Compare
dfederm
reviewed
Jan 31, 2024
dfederm
reviewed
Jan 31, 2024
dfederm
reviewed
Jan 31, 2024
dfederm
reviewed
Jan 31, 2024
dfederm
reviewed
Jan 31, 2024
johnterickson
commented
Feb 2, 2024
dfederm
reviewed
Feb 2, 2024
dfederm
reviewed
Feb 2, 2024
dfederm
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent package version conflicts between the plugin and MSBuild, we'll ILRepack our dependencies.