Skip to content

MSRec not building because of warning in openssl #41

@smainier

Description

@smainier

MSRSec has a link to openssl@3d753b0cefaa7e3d4b5d12d7805b20fabff1f385 (on the branch OpenSSL_1_1_1-stable) but this version of openssl doesn't build correctly with the compiler I'm using (arm-gnu-toolchain-11.3.rel1). The compilation stops because of this warning:

aarch64-none-linux-gnu-gcc -I/home/rpbeds/myagent/_work/1/s/MSRSec/external/ossl/include -fno-builtin -ffreestanding -nostdinc -mstrict-align -fshort-wchar -DOPENSSL_IMPLEMENTS_strncasecmp -DOPENSSL_NO_SOCK -DNO_SYSLOG -DOPENSSL_NO_DEPRECATED -DOPENSSL_NO_DGRAM -DOPENSSL_NO_UI_CONSOLE -DOPENSSL_NO_SOCK -DOPENSSL_NO_HW -DOPENSSL_NO_STDIO -DNO_CHMOD -DOPENSSL_NO_POSIX_IO -DRAND_DRBG_GET_RANDOM_NONCE -fPIC -fPIE -Os -Werror    -I. -Icrypto/include -Iinclude -Icrypto/ec/curve448/arch_32 -Icrypto/ec/curve448  -Wall -O3 --static -g -Os -DOPENSSL_USE_NODELETE -DOPENSSLDIR="\"/opt/openssl\"" -DENGINESDIR="\"/opt/openssl/lib/engines-1.1\"" -DNDEBUG -DOPENSSL_API_COMPAT=0x10100000L  -MMD -MF crypto/ec/curve448/f_generic.d.tmp -MT crypto/ec/curve448/f_generic.o -c -o crypto/ec/curve448/f_generic.o crypto/ec/curve448/f_generic.c
crypto/ec/curve448/f_generic.c:21:27: error: argument 1 of type 'uint8_t[56]' {aka 'unsigned char[56]'} with mismatched bound [-Werror=array-parameter=]
   21 | void gf_serialize(uint8_t serial[SER_BYTES], const gf x, int with_hibit)
      |                   ~~~~~~~~^~~~~~~~~~~~~~~~~
In file included from crypto/ec/curve448/f_generic.c:12:
crypto/ec/curve448/field.h:65:28: note: previously declared as 'uint8_t *' {aka 'unsigned char *'}
   65 | void gf_serialize(uint8_t *serial, const gf x, int with_highbit);
      |                   ~~~~~~~~~^~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:2731: crypto/ec/curve448/f_generic.o] Error 1

This warning has been corrected in more recent versions of OpenSSL, including branch 1_1_1. (For example, the version https://github.com/openssl/openssl/releases/tag/OpenSSL_1_1_1v doesn't have this warning anymore)

Can you correct the link to openssl in MSRSec source code?

Thanks,
Stephane

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions