Skip to content

Do not warn for overridden messages#188

Merged
sailro merged 1 commit into
mainfrom
fix-UNT0021-for-overrides
Oct 19, 2021
Merged

Do not warn for overridden messages#188
sailro merged 1 commit into
mainfrom
fix-UNT0021-for-overrides

Conversation

@sailro
Copy link
Copy Markdown
Member

@sailro sailro commented Oct 14, 2021

Fixes #187

Checklist

  • I have read the Contribution Guide ;
  • There is an approved issue describing the change when contributing a new analyzer or suppressor ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

We should not warn for overridden messages, given they will use the scope of the member definition. This rule is only interesting for regular messages. So check the IsOverride on the method symbol.

@sailro sailro requested a review from jbevain October 14, 2021 15:10
@sailro sailro requested a review from a team as a code owner October 14, 2021 15:10
@sailro sailro merged commit 40886c9 into main Oct 19, 2021
@sailro sailro deleted the fix-UNT0021-for-overrides branch October 19, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UNT0021 falsely flags StateMachineBehaviour messages

2 participants