Add NPR Rendering to GraphicsTools/StandardShader#109
Add NPR Rendering to GraphicsTools/StandardShader#109Cameron-Micka merged 5 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
This is amazing! What a wonderful idea and great execution. I added a few comments mostly about how to charge how the feature is enabled in the shader GUI. Once that is addressed this looks good to merge.
Also had fun doing some testing:

Also, if the Tokyo HoloLens Meetup was recored it would be fun to watch your segment. 😊
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsLighting.hlsl
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs
Outdated
Show resolved
Hide resolved
|
@Cameron-Micka |
Cameron-Micka
left a comment
There was a problem hiding this comment.
Tested the latest changes, thank you for responding to the feedback. It looks wonderful! This is good to merge after fixing the "Could not find MaterialProperty" exception and fixing the small merge conflicts. 😊
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandard.shader
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsLighting.hlsl
Outdated
Show resolved
Hide resolved
|
@Cameron-Micka |
Cameron-Micka
left a comment
There was a problem hiding this comment.
Looks great! This is ready to merge.


Overview
NPR functionality has been added to the light mode of GraphicsTools/Standard shaders.
Please see the following video for the actual operation.
https://youtu.be/rB6KaXwDAB4
The use of MeshOutline enables comic-like rendering.
I would like to add new features to ToonShader in the future, but even at this point, we think it is possible to create some very interesting expressions.
Personally, I think that the ability to use the existing StandardShader features in conjunction with the MeshOutline allows for a much greater variety of expressions!
Changes
Verification
https://youtu.be/rB6KaXwDAB4
Additional
@Cameron-Micka
Sorry I'm a little late as I was learning the new LightMode process!
TokyoHoloLensMeetup will be held on 10/12 in Japan!
I will be presenting MRGT in a 5 minute slot. I'm off to talk about what MRGT has to offer, including this NPR feature!