Skip to content

Add NPR Rendering to GraphicsTools/StandardShader#109

Merged
Cameron-Micka merged 5 commits intomicrosoft:mainfrom
HoloMoto:holomoto/NPRRendering
Oct 18, 2022
Merged

Add NPR Rendering to GraphicsTools/StandardShader#109
Cameron-Micka merged 5 commits intomicrosoft:mainfrom
HoloMoto:holomoto/NPRRendering

Conversation

@HoloMoto
Copy link
Copy Markdown
Collaborator

@HoloMoto HoloMoto commented Oct 11, 2022

Overview

NPR functionality has been added to the light mode of GraphicsTools/Standard shaders.

Please see the following video for the actual operation.

https://youtu.be/rB6KaXwDAB4

The use of MeshOutline enables comic-like rendering.

 I would like to add new features to ToonShader in the future, but even at this point, we think it is possible to create some very interesting expressions.

 Personally, I think that the ability to use the existing StandardShader features in conjunction with the MeshOutline allows for a much greater variety of expressions!

Changes

Verification

https://youtu.be/rB6KaXwDAB4

image

Additional

@Cameron-Micka
 Sorry I'm a little late as I was learning the new LightMode process!

 TokyoHoloLensMeetup will be held on 10/12 in Japan!
I will be presenting MRGT in a 5 minute slot. I'm off to talk about what MRGT has to offer, including this NPR feature!

Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! What a wonderful idea and great execution. I added a few comments mostly about how to charge how the feature is enabled in the shader GUI. Once that is addressed this looks good to merge.

Also had fun doing some testing:
image

image

Also, if the Tokyo HoloLens Meetup was recored it would be fun to watch your segment. 😊

@HoloMoto
Copy link
Copy Markdown
Collaborator Author

@Cameron-Micka
I've incorporated the Corrections !
It certainly needed to be used in conjunction with DistanceLight!
Also fixed the overlap between NPRRendering and Rendering. (I need to get better acquainted with the English language...)
20221016185943

Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the latest changes, thank you for responding to the feedback. It looks wonderful! This is good to merge after fixing the "Could not find MaterialProperty" exception and fixing the small merge conflicts. 😊

@HoloMoto
Copy link
Copy Markdown
Collaborator Author

@Cameron-Micka
Thank you!
I've corrected the two points you made!

Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is ready to merge.

@Cameron-Micka Cameron-Micka merged commit bf06f3e into microsoft:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPR Rendering for StandardShader

2 participants