#135 propertyDisplay#136
Merged
Cameron-Micka merged 1 commit intomicrosoft:mainfrom Jan 5, 2023
Merged
Conversation
Cameron-Micka
approved these changes
Jan 3, 2023
Member
Cameron-Micka
left a comment
Cameron-Micka
left a comment
There was a problem hiding this comment.
Looks great! Made one small comment, feel free to accept or ignore and I can merge. 😊
| if (PropertyEnabled(hoverLight) || PropertyEnabled(proximityLight) || PropertyEnabled(borderLight)) | ||
| { | ||
| materialEditor.ShaderProperty(fluentLightIntensity, Styles.fluentLightIntensity); | ||
| materialEditor.ShaderProperty(fluentLightIntensity, Styles.fluentLightIntensity, 2); |
Member
There was a problem hiding this comment.
One design suggestion, I wonder if it makes sense to move this property to the top?
That way it looks like it belongs to Hover Light, Proximity Light, and Border Light, rather than just Border Light.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The GraphicsStandard shader properties LightIntensity and EdgeSmoothnessMode are properties commonly used by multiple properties.
Previously, they were displayed on the layout instead of being child properties with spaces.
For this reason, we felt that some users may not notice them.
In fact, until I started working on this issue, I was unaware of it and attributed it to a display bug.
So I modified the layout to distinguish it from the others and make it easier to understand.
However, I honestly think there may be a better way to tackle this issue.
Changes
Verification
no