Skip to content

Fixing additional errors presented in Unity package validations#205

Merged
Cameron-Micka merged 2 commits intomicrosoft:mainfrom
AMollis:user/amollis/main/fix-additional-validation-errors-for-upm
Jan 18, 2024
Merged

Fixing additional errors presented in Unity package validations#205
Cameron-Micka merged 2 commits intomicrosoft:mainfrom
AMollis:user/amollis/main/fix-additional-validation-errors-for-upm

Conversation

@AMollis
Copy link
Copy Markdown
Contributor

@AMollis AMollis commented Jan 18, 2024

Overview

Fixing additional errors presented in Unity package validations, and download grading validation package due to publishing bugs.

Unity's package validation requires uncompressed image assets. So, I've converted some remaining JPGs to PNGs.

The com.unity.asset-store-validation version 3.0.0 is not compatible with Unity publishing system. As such, we need to downgrade to version 0.2.1

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks great! Thank you.

@Cameron-Micka Cameron-Micka merged commit 4497602 into microsoft:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants