Fix the backwards-incompatible enum change#5513
Merged
wiwei merged 1 commit intomicrosoft:prerelease/2.0.0_stabilizationfrom Aug 5, 2019
Merged
Fix the backwards-incompatible enum change#5513wiwei merged 1 commit intomicrosoft:prerelease/2.0.0_stabilizationfrom
wiwei merged 1 commit intomicrosoft:prerelease/2.0.0_stabilizationfrom
Conversation
A previous change to this updated an existing enum by adding a value in the middle of the enum - this is backwards incompatible because the same value is persisted in various profiles, where enums are stored as integer values, rather than string values. This means that something that used to refer to "pinch" now referred to this new thing, and the same off-by-one problem would affect all of the other options below the new enum
david-c-kline
approved these changes
Aug 5, 2019
|
/azp run stabilization_pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
With this change, the finger still gets offset, @MenelvagorMilsom FYI. This change is purely about fixing up the pinch/click functionality to work. |
Troy-Ferrell
approved these changes
Aug 5, 2019
Contributor
Author
|
/azp run mrtk_docs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change to this updated an existing enum by adding a value in the middle of the enum - this is backwards incompatible because the same value is persisted in various profiles, where enums are stored as integer values, rather than string values.
This means that something that used to refer to "pinch" now referred to this new thing, and the same off-by-one problem would affect all of the other options below the new enum
See change:
#5495
Original issue:
#5450
Current issue:
#5506