Skip to content

Solver Examples & Documentation Updates#5514

Merged
david-c-kline merged 13 commits intomicrosoft:prerelease/2.0.0_stabilizationfrom
Troy-Ferrell:users/trferrel/solvers-examples-docs
Aug 5, 2019
Merged

Solver Examples & Documentation Updates#5514
david-c-kline merged 13 commits intomicrosoft:prerelease/2.0.0_stabilizationfrom
Troy-Ferrell:users/trferrel/solvers-examples-docs

Conversation

@Troy-Ferrell
Copy link
Contributor

@Troy-Ferrell Troy-Ferrell commented Aug 5, 2019

Overview

This change address additional issues with the Solver example scenes & updates the solver documentation. There are additional minor fixes discovered for Solvers in here as well. See list below for all change details

  • Redesigned Solver example scene to be functional & easier to understand
  • Provided example usage of InBetween in scene
  • Remove SwapVolume script
  • Delete outdated Solver example prefabs (most were nonfunctional)
  • Updated solver text panel in example scene
  • Updated SolverHandler DestroyImmediate to Destroy
  • Fix SolverHandler issue in editor when destroying tracked transform unnecessarily
  • Fixed inspector isssue with enum popups not working with prefabs well
  • Fixed InBetween SecondTrackedTargetType to not show obsolete enum possibilites
  • Added warning to SurfaceMagnetism component for the MagneticSurfaces property. One common mistake is not marking a SurfaceMagnetism gameObject as "Ignore Raycast" so it doesn't "Magnetize" against itself
  • Added (Obsolete) term to TrackedObjectType summaries
  • SurfaceMagnetism did not check SolverHandler.TransformTarget was not null on raycast calculation
  • Add new InBetween documentation with images & gif
  • Added sections on Orbital & RadialView & SurfaceMagnetism to cover key propertise & common mistakes
  • Also added doc link button to SolverHandler

image

SolverExampleScene

Changes

Verification

Ran all playmode & editmode tests
Utilize Solvers in new example scene

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

…rfaceMagnetismInspector.cs

Co-Authored-By: Will <wiwei@microsoft.com>
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 5, 2019
@Troy-Ferrell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@david-c-kline david-c-kline merged commit 6c9ee13 into microsoft:prerelease/2.0.0_stabilization Aug 5, 2019
@cre8ivepark
Copy link
Contributor

Beautiful!

@Troy-Ferrell Troy-Ferrell deleted the users/trferrel/solvers-examples-docs branch August 8, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants