Fix for issue #5423#5528
Conversation
|
@keveleigh I think we were just chatting about this last week - was this one of the options you were thinking about? |
|
Unfortunately, I don't believe just this change fixes it (after #5250). I implemented this locally last week (keveleigh@ba647fc) and saw incorrect behavior in mrtk_dev. I'm thinking through a combination of reverting #5250 and adding this change as part of more clearly defining the expected data from source pose events (world space vs local space). |
@keveleigh is this something you have the bandwith to try? What was the undesirable behavior that you observed, so that @anuraag016 can try it out as well? |
I've blocked out some time tomorrow to focus on some MRTK issues, including this one!
After teleporting, the controllers were in an unexpected location. I had originally fixed that with #5250, which is in mrtk_dev but not RC2.1, but I'm no longer convinced I fixed it correctly, after the issue @anuraag016 reported here. Combining the two fixes breaks things again though, from what I experienced |
Due to microsoft#5250's change plus microsoft#5528's change to parent the controllers to the playspace
|
@wiwei @davidkline-ms I believe this PR is ready for review now! (also just force pushed this to be built off stabilization instead of dev) |
keveleigh
changed the base branch from
mrtk_development
to
prerelease/2.0.0_stabilization
keveleigh
changed the base branch from
prerelease/2.0.0_stabilization
to
mrtk_development
Fix for issue microsoft#5423 Controllers shown at original place after teleporting in VR. The fix is in the BaseController.cs file. In the function: protected virtual bool TryRenderControllerModel(Type controllerType, InputSourceType inputSourceType) we add MixedRealityPlayspace.AddChild(controllerObject.transform); This line should actually be moved inside TryAddControllerModelToSceneHierarchy function so that even if we use the platform controller visualization, they will be correctly added to under MixedRealityPlaySpace game object.
Due to microsoft#5250's change plus microsoft#5528's change to parent the controllers to the playspace
keveleigh
force-pushed
the
fix_issue5423
branch
from
647b0ca to
385965e
Compare
keveleigh
changed the base branch from
mrtk_development
to
prerelease/2.0.0_stabilization
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
left a comment
david-c-kline
left a comment
There was a problem hiding this comment.
Good fixes, nice collaboration!
5 participants
Fix for issue #5423 Controllers shown at original place after teleporting in VR.
Overview
This fix addresses the issue #5423 Controllers shown at original place after teleporting in VR.
Changes
The fix is in the BaseController.cs file.
In the function:
protected virtual bool TryRenderControllerModel(Type controllerType, InputSourceType inputSourceType)
we add MixedRealityPlayspace.AddChild(controllerObject.transform);
This line should actually be moved inside TryAddControllerModelToSceneHierarchy function
so that even if we use the platform controller visualization, they will be correctly added to under MixedRealityPlaySpace game object.