Skip to content

Conversation

@CDiaz-MS
Copy link
Contributor

@CDiaz-MS CDiaz-MS commented Nov 26, 2019

Overview

Added a guide on how to add support for Android and iOS with screenshots and updated the table of contents.

Addresses issue #6646 at the end of UsingARFoundation.md

Changes

  • Added CrossPlatform folder to docs, updated in toc.yml
  • Added UsingARFoundation.md
  • Updated UnityARCameraSettings.md

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@CDiaz-MS
Copy link
Contributor Author

/azp run mrtk_docs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@julenka julenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, found a few formatting issues. Have not tested myself. Are there any workarounds needed for iOS currently?

| **Android** | **iOS** | Comments |
| --- | --- | --- |
| AR Foundation <br/> Version: 1.5.0 - preview 6 | AR Foundation <br/> Version: 1.5.0 - preview 6 | For Unity 2018.4, this package is included as a preview. To view package: Window > Package Manager > Advanced > Show Preview Packages|
| ARCore XR Plugin <br/> Version: 2.1.2 | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table formatted incorrectly for me in the preview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blank cells in the table were intentional to indicate that ARKit is not needed for Android and ARCore is not needed for iOS. But if it looks like formatting issue then I can change the way the packages and versions are listed for each platform and unity version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see,

image

Ah, after staring at it for about 30 seconds more, I'm still not sure what the table is telling me :-) Would recommend maybe changing the visualization. Maybe just a bulletted list, one for android, one for iOS?

| **Android** | **iOS** |
| --- | --- |
| AR Foundation <br/> Version: 2.1.4 | AR Foundation <br/> Version: 2.1.4 |
| ARCore XR Plugin <br/> Version: 2.1.2 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table also formatted incorrectly in preview

@CDiaz-MS
Copy link
Contributor Author

Are there any workarounds needed for iOS currently?

@julenka
The only current workaround is mentioned at the bottom of the UsingARFoundation page to prevent the World Anchor error in Xcode

@CDiaz-MS
Copy link
Contributor Author

/azp run mrtk_docs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CDiaz-MS
Copy link
Contributor Author

/azp run mrtk_docs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@david-c-kline david-c-kline merged commit bfe072f into microsoft:prerelease/2.2.0_stabilization Nov 27, 2019
@david-c-kline david-c-kline added this to the MRTK 2.2.0 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants