Skip to content

Conversation

@Troy-Ferrell
Copy link
Contributor

Overview

This change creates two new materials to be used directly with the default hand joint mesh visualization.

One material for the hand joint cubes. This new material is opaque instead of transparent allowing for true dynamic batching of all joints into a combined draw call.

One material for the hand joint index tip spheres. This material turns off hover light and other unnecessary items and turns on GPU instancing so both index tips are drawn in one call.

Before
image

After
image

Changes

  • Fixes: # .

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@Troy-Ferrell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Troy-Ferrell
Copy link
Contributor Author

NearInteractionTouchableDistance passes for me locally. Running again

@Troy-Ferrell
Copy link
Contributor Author

/azp run mrtk_PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thalbern thalbern merged commit 5330d91 into microsoft:mrtk_development Dec 4, 2019
@Troy-Ferrell Troy-Ferrell deleted the users/trferrel/optimize-handmeshjoints branch December 10, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants