Added AppBar support for BoundsControl and fixed configuration bugs #7096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing public setters to configure bounds control in code
…haven't been created yet finished migration handler (added folder generation and check, added appbar migration) made app bar use generic target that implements new IBoundsTargetProvider so we can use both boundscontrol and boundingbox with it deprecated boundingbox specific methods in boundingboxhelper / added generic variants of methods
…zation' into user/bethalha/bc_examples
…so changed type to monobehaviour to prepare for upcoming support of bounds control
…setting of dirty flag - else serialization stomps over our code change
This was referenced Jan 20, 2020
added test for far interaction app bar manipulation
adjusted comment in play mode tests
thalbern
requested review from
CDiaz-MS,
david-c-kline,
keveleigh and
wiwei
as code owners
Contributor
Author
|
/azp run |
1 similar comment
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run stabilization_pr |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
david-c-kline
left a comment
david-c-kline
left a comment
There was a problem hiding this comment.
just a couple of small comments / questions
Assets/MixedRealityToolkit.SDK/Experimental/Features/UX/BoundsControl/BoundsControl.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit.SDK/Experimental/Features/UX/BoundsControl/BoundsControl.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/BoundingBox/BoundingBox.cs
Show resolved
Hide resolved
Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/BoundingBox/IBoundsTargetProvider.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit.Tests/EditModeTests/Experimental/BoundsControlTests.cs
Outdated
Show resolved
Hide resolved
keveleigh
reviewed
Jan 23, 2020
Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/BoundingBox/IBoundsTargetProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…added missing braces and fixed some whitespace issues
| } | ||
|
|
||
|
|
||
| private bool IsInitialized() |
Contributor
There was a problem hiding this comment.
Couldn't we have this as a private property?
Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/BoundingBox/BoundingBox.cs
Show resolved
Hide resolved
keveleigh
reviewed
Jan 23, 2020
Assets/MixedRealityToolkit.Tests/EditModeTests/Experimental/BoundsControlTests.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
BoundsControl can now be used with AppBar:
-- changed BoundingBox utility to be more generic -> now works on collider bounds instead of bounding box
-- deprecated old bounding box specific methods in BoundingBoxUtility
-- changed target of AppBar to work on any component implementing the new IBoundsTargetProvider interface (and made BoundingBox and BoundsControl implement it)
fixed nullptr access when modifying certain Bounds Control configuration properties in code
fixed handling of show wireframe flag
added property get / set to allow for code configured bounding box / bounds control
Added tests:
-- Playmode test for manipulating a bounds control via AppBar
-- Editmode test that makes sure all bounds control configuration values can be set without anything blowing up
Changes