refactor: bring the visibility of vmSize to main.bicep #152
Merged
Roopan-Microsoft merged 6 commits intodevfrom Jul 1, 2025
Merged
refactor: bring the visibility of vmSize to main.bicep #152Roopan-Microsoft merged 6 commits intodevfrom
Roopan-Microsoft merged 6 commits intodevfrom
Conversation
feat: Merge the AVM WAF and Azd Quota check changes from dev to main
DocGailZhou
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Roopan-Microsoft
approved these changes
Jul 1, 2025
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Ritesh-Microsoft
pushed a commit
that referenced
this pull request
Oct 10, 2025
refactor: bring the visibility of vmSize to main.bicep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Key Goal: Bring visibility of VmSize to main.bicep where a default value is set if user does not provide it. The rest of the code uses this value. Why? We ran into issues that certain regions cannot create the VM due to availability or capacity. We need to bring this to the attention of users so they can address it gracefully. I have tested code for both sandbox and waf-aligned.
Optional feature added: azure.v2.yaml for azd v2 users. If accepted, need to add description in Deployment Guide. I will leave this up to the team on this new file.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
I have tested both sandbox and waf-aligned deployments and verified application works.
Other Information
new and recommended: created azure.v2.yaml. for azd v2 users, they need to do this (add to deployment guide)
azd up --azure-config azure.v2.yaml