feat: Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut#431
Merged
Merged
Conversation
…update related comments and method calls. Co-authored-by: Copilot <copilot@github.com>
…e deployment details such as triggered by and branch information Co-authored-by: Copilot <copilot@github.com>
…r WAF configuration Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…pp_url input Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CI/CD deployment ergonomics and notifications by introducing an “enable scalability” deployment switch, enhancing Azure resource-group tagging, upgrading the notification email template formatting, and updating the frontend auth UI wording from “Logout” to “Sign out”.
Changes:
- Added
enable_scalability/ENABLE_SCALABILITYinputs and propagated them through deployment workflows (with WAF-specific parameter injection viajq). - Updated notification workflow emails to use richer HTML formatting with “status pill” indicators.
- Renamed frontend auth action from
logouttosignOutand updated the UserProfile menu label to “Sign out”.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/msal-auth/useAuth.ts |
Renames the exposed auth action from logout to signOut and updates log messages accordingly. |
src/frontend/src/components/Header/UserProfile.tsx |
Updates menu handler wiring and user-facing label to “Sign out”. |
.github/workflows/job-send-notification.yml |
Replaces plain-table email bodies with richer HTML templates and pill-style status indicators. |
.github/workflows/job-deploy.yml |
Adds enable_scalability input, adds/updates RG Owner tagging, and propagates scalability flag to downstream jobs. |
.github/workflows/job-deploy-windows.yml |
Adds ENABLE_SCALABILITY input and sets enableScalability in WAF parameters via jq. |
.github/workflows/job-deploy-linux.yml |
Adds ENABLE_SCALABILITY input and sets enableScalability in WAF parameters via jq. |
.github/workflows/deploy-v2.yml |
Adds enable_scalability workflow_dispatch input and propagates it through validation outputs into the orchestrator call. |
.github/workflows/deploy-orchestrator.yml |
Wires enable_scalability through orchestrator inputs into downstream deploy workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/job-send-notification.yml:611
- The HTML email body interpolates
${EXISTING_URL}directly into anhrefattribute without HTML/attribute escaping. Since this is a workflow input, a crafted value containing quotes can inject markup into the email. Please HTML-escape (or strictly validate) this value before embedding it into the template.
<table width="100%" cellpadding="0" cellspacing="0" style="margin-bottom:28px;">
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280; width:140px;">Target URL</td>
<td style="padding:8px 0; font-size:13px;"><a href="${EXISTING_URL}" style="color:#2563eb; text-decoration:none; font-family:'Cascadia Code','Courier New',monospace;">${EXISTING_URL}</a></td></tr>
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Triggered By</td>
<td style="padding:8px 0; font-size:13px; color:#111827;">${{ github.actor }}</td></tr>
<tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Branch</td>
<td style="padding:8px 0; font-size:13px; color:#111827; font-family:'Cascadia Code','Courier New',monospace;">${{ env.BRANCH_NAME }}</td></tr>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 13, 2026
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and new features to the deployment workflows and the frontend authentication UX. The main highlights are the addition of an "Enable Scalability" option for deployments (especially when WAF is enabled), improved resource group tagging in Azure, and a consistent renaming of the "Logout" action to "Sign out" in the frontend for clarity and accessibility.
Deployment Workflow Enhancements:
enable_scalability/ENABLE_SCALABILITYinput to all deployment workflows (deploy-orchestrator.yml,deploy-v2.yml,job-deploy.yml,job-deploy-linux.yml,job-deploy-windows.yml). This option allows users to enable scalability features during deployment, particularly when WAF is enabled. The value is passed through validation and set in the deployment parameters usingjq. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Ownertag is added or updated with the GitHub actor's name for better tracking and management.Frontend Authentication Improvements:
logouttosignOutin both theUserProfilecomponent and theuseAuthhook. [1] [2] [3] [4] [5] [6] [7]These changes collectively improve deployment flexibility, resource management, and frontend user experience.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information