Skip to content

feat: Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut#431

Merged
Roopan-Microsoft merged 11 commits into
devfrom
psl-Tag-owner-Add-ScalabilityInput
May 13, 2026
Merged

feat: Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut#431
Roopan-Microsoft merged 11 commits into
devfrom
psl-Tag-owner-Add-ScalabilityInput

Conversation

@Vamshi-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces several improvements and new features to the deployment workflows and the frontend authentication UX. The main highlights are the addition of an "Enable Scalability" option for deployments (especially when WAF is enabled), improved resource group tagging in Azure, and a consistent renaming of the "Logout" action to "Sign out" in the frontend for clarity and accessibility.

Deployment Workflow Enhancements:

  • Added a new enable_scalability/ENABLE_SCALABILITY input to all deployment workflows (deploy-orchestrator.yml, deploy-v2.yml, job-deploy.yml, job-deploy-linux.yml, job-deploy-windows.yml). This option allows users to enable scalability features during deployment, particularly when WAF is enabled. The value is passed through validation and set in the deployment parameters using jq. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]
  • Improved Azure resource group tagging: When a resource group is created or an existing one is used, an Owner tag is added or updated with the GitHub actor's name for better tracking and management.
  • Refined workflow input descriptions and options for clarity (e.g., region names, WAF/EXP/build options, and resource cleanup). [1] [2]

Frontend Authentication Improvements:

  • Renamed the "Logout" action to "Sign out" in the user profile menu for better clarity and accessibility. Updated all related identifiers from logout to signOut in both the UserProfile component and the useAuth hook. [1] [2] [3] [4] [5] [6] [7]

These changes collectively improve deployment flexibility, resource management, and frontend user experience.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Vamshi-Microsoft and others added 10 commits May 11, 2026 16:13
…update related comments and method calls.

Co-authored-by: Copilot <copilot@github.com>
…e deployment details such as triggered by and branch information

Co-authored-by: Copilot <copilot@github.com>
…r WAF configuration

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…pp_url input

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 08:51
@Vamshi-Microsoft Vamshi-Microsoft changed the title Enhanced email template, Added owner tag to RG, Added enableScalability input defaults to false and Updated Logout to SignOut Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut May 13, 2026
@Vamshi-Microsoft Vamshi-Microsoft changed the title Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut feat: Enhance email template, add RG owner tag, scalability input, and renamed Logout to SignOut May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves CI/CD deployment ergonomics and notifications by introducing an “enable scalability” deployment switch, enhancing Azure resource-group tagging, upgrading the notification email template formatting, and updating the frontend auth UI wording from “Logout” to “Sign out”.

Changes:

  • Added enable_scalability / ENABLE_SCALABILITY inputs and propagated them through deployment workflows (with WAF-specific parameter injection via jq).
  • Updated notification workflow emails to use richer HTML formatting with “status pill” indicators.
  • Renamed frontend auth action from logout to signOut and updated the UserProfile menu label to “Sign out”.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/frontend/src/msal-auth/useAuth.ts Renames the exposed auth action from logout to signOut and updates log messages accordingly.
src/frontend/src/components/Header/UserProfile.tsx Updates menu handler wiring and user-facing label to “Sign out”.
.github/workflows/job-send-notification.yml Replaces plain-table email bodies with richer HTML templates and pill-style status indicators.
.github/workflows/job-deploy.yml Adds enable_scalability input, adds/updates RG Owner tagging, and propagates scalability flag to downstream jobs.
.github/workflows/job-deploy-windows.yml Adds ENABLE_SCALABILITY input and sets enableScalability in WAF parameters via jq.
.github/workflows/job-deploy-linux.yml Adds ENABLE_SCALABILITY input and sets enableScalability in WAF parameters via jq.
.github/workflows/deploy-v2.yml Adds enable_scalability workflow_dispatch input and propagates it through validation outputs into the orchestrator call.
.github/workflows/deploy-orchestrator.yml Wires enable_scalability through orchestrator inputs into downstream deploy workflow.
Comments suppressed due to low confidence (1)

.github/workflows/job-send-notification.yml:611

  • The HTML email body interpolates ${EXISTING_URL} directly into an href attribute without HTML/attribute escaping. Since this is a workflow input, a crafted value containing quotes can inject markup into the email. Please HTML-escape (or strictly validate) this value before embedding it into the template.
                  <table width="100%" cellpadding="0" cellspacing="0" style="margin-bottom:28px;">
                    <tr><td style="padding:8px 0; font-size:13px; color:#6b7280; width:140px;">Target URL</td>
                        <td style="padding:8px 0; font-size:13px;"><a href="${EXISTING_URL}" style="color:#2563eb; text-decoration:none; font-family:'Cascadia Code','Courier New',monospace;">${EXISTING_URL}</a></td></tr>
                    <tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Triggered By</td>
                        <td style="padding:8px 0; font-size:13px; color:#111827;">${{ github.actor }}</td></tr>
                    <tr><td style="padding:8px 0; font-size:13px; color:#6b7280;">Branch</td>
                        <td style="padding:8px 0; font-size:13px; color:#111827; font-family:'Cascadia Code','Courier New',monospace;">${{ env.BRANCH_NAME }}</td></tr>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/job-deploy.yml
Comment thread .github/workflows/deploy-v2.yml
Comment thread .github/workflows/job-deploy-linux.yml Outdated
Comment thread .github/workflows/job-deploy-windows.yml Outdated
Comment thread .github/workflows/job-send-notification.yml
Comment thread .github/workflows/job-send-notification.yml
Comment thread .github/workflows/job-send-notification.yml
@Roopan-Microsoft Roopan-Microsoft merged commit 81f2af6 into dev May 13, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants