fix(infra): remove enableAnalyticalStorage on Cosmos DB account creation#432
Merged
Merged
Conversation
Azure no longer supports enabling Analytical Storage during Cosmos DB account creation, which caused deployments to fail with: BadRequest: Enabling Analytical Storage during account creation is no longer supported. The flag was set to true in infra/modules/cosmosDb.bicep but no container in this solution configures analyticalStorageTtl, so the feature was unused. Removing the explicit value lets the AVM module default (false) apply, unblocking deployments. Regenerated infra/main.json from the updated Bicep. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Shreyas-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated Cosmos DB “Analytical Storage enablement at account creation time” setting from the infrastructure module to unblock fresh deployments that currently fail with BadRequest: Enabling Analytical Storage during account creation is no longer supported.
Changes:
- Removed
enableAnalyticalStorage: truefrom the Cosmos DB account AVM module invocation so the module default (false) applies. - Regenerated
infra/main.jsonto keep the compiled ARM template in sync with the Bicep source (including deterministicdependsOnreordering and updated template hashes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/modules/cosmosDb.bicep | Stops passing enableAnalyticalStorage during Cosmos DB account creation to avoid Azure rejecting the request. |
| infra/main.json | Updates the compiled template output to reflect the Bicep change (removes the parameter and updates hashes/order). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 14, 2026
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes minor adjustments to the infrastructure code, primarily in the
infra/main.jsonandinfra/modules/cosmosDb.bicepfiles. The main changes involve updating dependency ordering and removing theenableAnalyticalStorageparameter from Cosmos DB account creation. These updates help ensure correct resource provisioning and simplify the Cosmos DB configuration.Infrastructure dependency and configuration updates:
infra/main.jsonto ensure correct resource deployment sequencing. [1] [2]enableAnalyticalStorageparameter from Cosmos DB account creation in bothinfra/main.jsonandinfra/modules/cosmosDb.bicep, simplifying the Cosmos DB configuration. [1] [2]Template metadata updates:
_generator.templateHashfields ininfra/main.jsonto reflect changes in the template. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information