Skip to content

Conversation

@ljshou
Copy link
Member

@ljshou ljshou commented Apr 28, 2019

No description provided.

{
"license": "Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.",
"tool_version": "1.1.0",
"model_description": "This model is used for knowledge distillation for query binary classifier",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for knowledge distillation for query binary classifier? More grammatical description is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woailaosang do you have any suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is very good! I have run it smoothly.
Only some suggestions about name, description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for knowledge distillation for query binary classifier? More grammatical description is better.

@ljshou and I think it is okay

tools/AUC.py Outdated
def main(params):
prediction, label = read_tsv(params)
auc = calculate_AUC(prediction, label)
print("auc is ", auc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print("AUC is ", auc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename : "calculate_AUC.py" is better than "AUC.py", I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Zhijie. @chengfx please modify.

filename : "calculate_AUC.py" is better than "AUC.py", I think.

thanks Zhijie. @chengfx please modify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print("AUC is ", auc)

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Zhijie. @chengfx please modify.

filename : "calculate_AUC.py" is better than "AUC.py", I think.

thanks Zhijie. @chengfx please modify.

thanks @woailaosang and @ljshou, done

@chengfx chengfx requested a review from woailaosang April 28, 2019 06:27
@ljshou ljshou merged commit eaef926 into master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants