-
Notifications
You must be signed in to change notification settings - Fork 192
add code for query binary classifier knowledge distillation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| "license": "Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.", | ||
| "tool_version": "1.1.0", | ||
| "model_description": "This model is used for knowledge distillation for query binary classifier", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for knowledge distillation for query binary classifier? More grammatical description is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woailaosang do you have any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is very good! I have run it smoothly.
Only some suggestions about name, description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for knowledge distillation for query binary classifier? More grammatical description is better.
@ljshou and I think it is okay
tools/AUC.py
Outdated
| def main(params): | ||
| prediction, label = read_tsv(params) | ||
| auc = calculate_AUC(prediction, label) | ||
| print("auc is ", auc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print("AUC is ", auc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filename : "calculate_AUC.py" is better than "AUC.py", I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print("AUC is ", auc)
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Zhijie. @chengfx please modify.
filename : "calculate_AUC.py" is better than "AUC.py", I think.
thanks Zhijie. @chengfx please modify.
thanks @woailaosang and @ljshou, done
No description provided.