Refine comments and minor adjustments#220
Merged
srinathsetty merged 6 commits intomicrosoft:mainfrom Aug 21, 2023
zk-Lee:main
Merged
Refine comments and minor adjustments#220srinathsetty merged 6 commits intomicrosoft:mainfrom zk-Lee:main
srinathsetty merged 6 commits intomicrosoft:mainfrom
zk-Lee:main
Conversation
This reverts commit b8e4208.
This was referenced Aug 21, 2023
Closed
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Aug 23, 2023
* feat: add secp/secq cycle (microsoft#199) * feat: add secp/secq * chore: add tests for poseidon and spartan * rename to secp_secq * chore: add secp_secq tests * chore: link to halo2curves git fork * fix: cpu_best_multiexp from mod.rs, shake.input() to update(), pasta to_coordinates(), shake.xof_result() to finalize_xof() * chore: remove extra spaces * chore: use grumpkin implementation of to_coordinates() * chore: merge upstream, fix conflicts * chore: be consistent with bn256_grumpkin.rs + rust fmt * Refine comments and minor adjustments (microsoft#220) * Refine comments * Eliminate redundant computation * 3bc248d Revert "Refine comments" This reverts commit 3bc248d. * Revert "Eliminate redundant computation" This reverts commit b8e4208. * Fix comments typos * Eliminate redundant computation * chore: fix redundant clone --------- Co-authored-by: Pierre <pdaixmoreux@gmail.com> Co-authored-by: JunheeLee <101318348+Jun-Hee-Lee@users.noreply.github.com>
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Jan 1, 2024
* refactor: Refactor and add test module for `padded` function - Simplified the `padded` function in `ppsnark.rs` - test case for the `padded` function * refactor: clean up some unnnecessary wraps * refactor: enforce stricter linting rules - Updated clippy configuration by removing and adding specific lints for stricter code checks. * refactor: refactor sparse matrix iteration - Refactor `R1CSShapeSparkRepr` in `ppsnark.rs` - Restructure the main loop for simultaneous population of `row`, `col`, and `val_X` vectors. * clippy::use_self * feat: Move all Sumcheck engine related items to the sumcheck module - Introduced a new module `src/spartan/sumcheck/engine.rs`, - Changed the visibility status of the `sumcheck` module, making it visible within the `spartan` module. - Refactored the file structure as `src/spartan/sumcheck.rs` was renamed to `src/spartan/sumcheck/mod.rs` and a new submodule `engine` was added within the `spartan` crate. - Refactored the import structures in `ppsnark` and `sumcheck::engine`, moving several items to `sumcheck::engine`. * fixup! clippy::use_self
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped
let (right, _) = right.split_at(n);sinceMultilinearPolynomial::newensures even length.