Skip to content

Conversation

@shaahji
Copy link
Collaborator

@shaahji shaahji commented Sep 25, 2025

Implicitly add olive version to saved onnx model proto

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@shaahji shaahji enabled auto-merge (squash) September 25, 2025 20:29
@xiaoyu-work
Copy link
Collaborator

This is little bit similar as this pass https://github.com/microsoft/Olive/blob/main/olive/passes/onnx/add_metadata.py#L63

@shaahji
Copy link
Collaborator Author

shaahji commented Sep 29, 2025

This is little bit similar as this pass https://github.com/microsoft/Olive/blob/main/olive/passes/onnx/add_metadata.py#L63

The implemented pass is doing a lot more work than what's need here. Inserting the Olive version needs to be implicit (i.e. user shouldn't have to do anything like adding a pass to the workflow). The only common code is probably 3 lines that queries the version.

@shaahji shaahji merged commit 910cbaf into main Oct 1, 2025
11 checks passed
@shaahji shaahji deleted the shaahji/ov branch October 1, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants