HfModelHandler: Check for tokenizer_config.json instead of try/else#2247
Merged
HfModelHandler: Check for tokenizer_config.json instead of try/else#2247
Conversation
xiaoyu-work
approved these changes
Nov 7, 2025
xiaoyu-work
pushed a commit
that referenced
this pull request
Nov 10, 2025
…2247) ## Describe your changes - the try/else solution is finicky. The errors when the tokenizer is not present depend on the versions as well as model. - Better solution to check for `tokenizer_config.json` like we do for the other files. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
tokenizer_config.jsonlike we do for the other files.Checklist before requesting a review
lintrunner -a(Optional) Issue link