Add size_on_disk API to OliveModelHandler and corresponding metric#2262
Merged
xiaoyu-work merged 1 commit intomainfrom Dec 11, 2025
Merged
Add size_on_disk API to OliveModelHandler and corresponding metric#2262xiaoyu-work merged 1 commit intomainfrom
xiaoyu-work merged 1 commit intomainfrom
Conversation
shaahji
force-pushed
the
shaahji/size_on_disk
branch
from
a9280ff to
3624ea4
Compare
xiaoyu-work
reviewed
Nov 19, 2025
| @property | ||
| def size_on_disk(self) -> int: | ||
| """Compute size of the model on disk.""" | ||
| model = self.load_model() |
Collaborator
There was a problem hiding this comment.
Do we need to count external data size?
Collaborator
Author
There was a problem hiding this comment.
Yes! Logic needs to account for weights as well.
shaahji
force-pushed
the
shaahji/size_on_disk
branch
3 times, most recently
from
986b501 to
35c8791
Compare
shaahji
force-pushed
the
shaahji/size_on_disk
branch
from
35c8791 to
69d8143
Compare
xiaoyu-work
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add size_on_disk API to OliveModelHandler and corresponding metric
Checklist before requesting a review
lintrunner -a(Optional) Issue link