Skip to content

Disable qdq to mnb fusion in test_mnb_to_qdq#2429

Merged
jambayk merged 2 commits intomainfrom
jambayk/mnb-qdq-fuse
Apr 22, 2026
Merged

Disable qdq to mnb fusion in test_mnb_to_qdq#2429
jambayk merged 2 commits intomainfrom
jambayk/mnb-qdq-fuse

Conversation

@jambayk
Copy link
Copy Markdown
Contributor

@jambayk jambayk commented Apr 21, 2026

Describe your changes

Latest ORT has QDQ to MatMulNBits rules for more cases now. We want to disable this fusion in the test_mnb_to_qdq test since we are trying to compare the original MNB model with the replacement QDQ model.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Copilot AI review requested due to automatic review settings April 21, 2026 19:49
@jambayk jambayk enabled auto-merge (squash) April 21, 2026 19:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an ONNX pass unit test to prevent newer ONNX Runtime versions from fusing the replacement QDQ graph back into MatMulNBits, so the test can continue validating behavior of the QDQ replacement model.

Changes:

  • Disables a specific ORT optimizer when creating the QDQ model InferenceSession in test_mnb_to_qdq.
  • Adds a short comment explaining why the optimizer is disabled.

Comment thread test/passes/onnx/test_mnb_to_qdq.py
Comment thread test/passes/onnx/test_mnb_to_qdq.py
@jambayk jambayk merged commit fe20993 into main Apr 22, 2026
15 checks passed
@jambayk jambayk deleted the jambayk/mnb-qdq-fuse branch April 22, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants