-
Notifications
You must be signed in to change notification settings - Fork 282
Switch to Microsoft.CodeAnalysis.PublicApiAnalyzers for validation #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt (2152 lines) to src/Microsoft.OpenApi/PublicAPI.Shipped.txt (1844 entries) - Generated PublicAPI.Shipped.txt and PublicAPI.Unshipped.txt files for both Microsoft.OpenApi and Microsoft.OpenApi.YamlReader projects - Added Microsoft.CodeAnalysis.PublicApiAnalyzers package reference in Directory.Build.props The conversion extracted 1843 public API declarations from the PublicApiGenerator format and converted them to the Microsoft.CodeAnalysis.PublicApiAnalyzers format: - Types (classes, interfaces, structs, enums, delegates) - Constructors - Methods - Properties (with get/set accessors) - Fields (including const fields) - Events - Enum values with their numeric assignments Note: Build validation and potential missing API entries will need to be addressed in follow-up work as the PublicApiAnalyzers may identify additional public APIs not captured in the original PublicApiGenerator output.
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
- Generated public API using PublicApiGenerator for Microsoft.OpenApi.YamlReader assembly - Converted to PublicApiAnalyzers format and added to PublicAPI.Unshipped.txt - Made static ReadFragment<T>(JsonNode...) method internal to resolve RS0016 and RS0026 analyzer errors - Resolved RS0016/RS0017 analyzer errors for YamlReader project - Note: RS0036 nullability annotation warnings remain but are separate from PublicAPI format issues Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
Jan 27, 2026
|
adrian05-ms
approved these changes
Jan 27, 2026
This was referenced Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Migration to Microsoft.CodeAnalysis.PublicApiAnalyzers
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.