Skip to content

Remove the YamlReaders folder in the Reader project and change the na… #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

Remove the YamlReaders folder in the Reader project and change the na… #56

merged 1 commit into from
Nov 3, 2017

Conversation

@xuzhg
Copy link
Contributor

@xuzhg xuzhg commented Nov 2, 2017

  1. Remove the YamlReaders folder in the Reader project

  2. Change the namespace

@msftclas
Copy link

msftclas commented Nov 2, 2017

@xuzhg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@PerthCharern
Copy link
Contributor

PerthCharern commented Nov 3, 2017

How come none of the unit tests need using Microsoft.OpenApi.Readers;? I know some tests don't belong there, but doesn't something like SchemaTests needs Microsoft.OpenApi.Readers to call OpenApiStreamReader?

@xuzhg
Copy link
Contributor Author

xuzhg commented Nov 3, 2017

No need the using.

I think maybe it's related to: [assembly: InternalsVisibleTo("Microsoft.OpenApi.Readers.Tests")], But I am not sure.

PerthCharern
PerthCharern approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@PerthCharern PerthCharern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern
Copy link
Contributor

PerthCharern commented Nov 3, 2017

That's good to know. New interesting C# feature today :D

@xuzhg xuzhg merged commit dca8aef into microsoft:master Nov 3, 2017
@xuzhg xuzhg deleted the ReadChanges branch November 3, 2017 05:28
baywet added a commit that referenced this pull request Nov 11, 2025
@baywet
Merge pull request #56 from BinkyLabs/chore/upstream-sync
b54a163 
Chore/upstream sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

1 more reviewer

@PerthCharern PerthCharern PerthCharern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xuzhg @msftclas @PerthCharern