Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

CompatHelper: bump compat for Makie to 0.16, (keep existing compat)#345

Merged
BrianGun merged 3 commits intomainfrom
compathelper/new_version/2022-01-08-00-11-19-219-01527713354
Feb 8, 2022
Merged

CompatHelper: bump compat for Makie to 0.16, (keep existing compat)#345
BrianGun merged 3 commits intomainfrom
compathelper/new_version/2022-01-08-00-11-19-219-01527713354

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jan 8, 2022

This pull request changes the compat entry for the Makie package from 0.15 to 0.15, 0.16.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@alfredclwong alfredclwong force-pushed the compathelper/new_version/2022-01-08-00-11-19-219-01527713354 branch from cf74215 to 70592b2 Compare January 8, 2022 00:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #345 (70592b2) into main (05d4200) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   52.02%   52.37%   +0.35%     
==========================================
  Files          84       84              
  Lines        8041     7759     -282     
==========================================
- Hits         4183     4064     -119     
+ Misses       3858     3695     -163     
Impacted Files Coverage Δ
src/RepeatingStructures/HexagonalLattice.jl 47.88% <0.00%> (-2.77%) ⬇️
src/Geometry/Primitives/Curves/BSpline.jl 66.66% <0.00%> (-1.61%) ⬇️
src/OpticSim.jl 87.50% <0.00%> (-1.39%) ⬇️
src/RepeatingStructures/Lattice.jl 20.00% <0.00%> (-0.97%) ⬇️
src/Geometry/Transform.jl 55.34% <0.00%> (-0.83%) ⬇️
src/Geometry/Primitives/AsphericSurface.jl 59.39% <0.00%> (-0.73%) ⬇️
src/Geometry/Primitives/Curves/Knots.jl 92.30% <0.00%> (-0.72%) ⬇️
src/GlassCat/generate.jl 89.58% <0.00%> (-0.62%) ⬇️
src/Geometry/CSG/CSG.jl 83.76% <0.00%> (-0.47%) ⬇️
src/GlassCat/GlassTypes.jl 43.33% <0.00%> (-0.32%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d4200...70592b2. Read the comment docs.

@BrianGun BrianGun enabled auto-merge (squash) February 8, 2022 00:12
@BrianGun BrianGun merged commit c909b0f into main Feb 8, 2022
@BrianGun BrianGun deleted the compathelper/new_version/2022-01-08-00-11-19-219-01527713354 branch February 8, 2022 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants