This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Conversation
Fixes #356
moved replacement of optic center of lenlets before the computation of projected eyeboxes, since the latter depends on the former.
adding more drawing functions to Example.jl so individual parts of system computation can be drawn.
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 52.38% 52.28% -0.11%
==========================================
Files 81 81
Lines 7763 7779 +16
==========================================
Hits 4067 4067
- Misses 3696 3712 +16
Continue to review full report at Codecov.
|
…cted eyeboxes is. Projection of eyebox onto display plane seems to be correct as does the replacement of the optical center. Maybe some local transform problem with ConvexPolygon, i.e., not having access to the correct local transform.
…ace. Was using values computed by an obsolete function.
galran
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #356
moved replacement of optic center of lenlets before the computation of projected eyeboxes, since the latter depends on the former.
adding more drawing functions to Example.jl so individual parts of system computation can be drawn.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration(s):
Checklist: