Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Fix placement of lenslet displays#357

Merged
BrianGun merged 4 commits intomainfrom
BrianGun/issue356
Jan 25, 2022
Merged

Fix placement of lenslet displays#357
BrianGun merged 4 commits intomainfrom
BrianGun/issue356

Conversation

@BrianGun
Copy link
Copy Markdown
Contributor

Fixes #356

moved replacement of optic center of lenlets before the computation of projected eyeboxes, since the latter depends on the former.

adding more drawing functions to Example.jl so individual parts of system computation can be drawn.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fixes #356

moved replacement of optic center of lenlets before the computation of projected eyeboxes, since the latter depends on the former.

adding more drawing functions to Example.jl so individual parts of system computation can be drawn.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #357 (2179107) into main (adc956e) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   52.38%   52.28%   -0.11%     
==========================================
  Files          81       81              
  Lines        7763     7779      +16     
==========================================
  Hits         4067     4067              
- Misses       3696     3712      +16     
Impacted Files Coverage Δ
src/RepeatingStructures/Multilens/Example.jl 0.00% <0.00%> (ø)
...RepeatingStructures/Multilens/LensletAssignment.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc956e...2179107. Read the comment docs.

…cted eyeboxes is. Projection of eyebox onto display plane seems to be correct as does the replacement of the optical center. Maybe some local transform problem with ConvexPolygon, i.e., not having access to the correct local transform.
…ace. Was using values computed by an obsolete function.
@BrianGun BrianGun merged commit f50eb53 into main Jan 25, 2022
@BrianGun BrianGun deleted the BrianGun/issue356 branch January 25, 2022 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix placement of lenslet displays

3 participants