This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Conversation
Fixes #359
BrianGun
changed the title
…cy on downloaded glasses. This was fragile and caused tests to sometimes fail.
…f otherexamples.jl. Which had the old SCHOTT glasses. Fixed to use hardcoded glasses.
…e replaced with locally defined glasses.
Fixes #359
removed redefinition of Examples_N_BK7
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 52.12% 54.51% +2.38%
==========================================
Files 81 81
Lines 7802 7802
==========================================
+ Hits 4067 4253 +186
+ Misses 3735 3549 -186
Continue to review full report at Codecov.
|
galran
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# Pull Request Template
## Description
choosecluster asserts that the cluster diameter is <= pupil diameter. It should actually be equal but because of roundoff error it is sometimes a bit larger. this caused assertion failures that shouldn't have happened. Used isapprox to compare cluster diameter and pupil diameter to make the assertion work properly.
Fixes # (359)
## Type of change
- [ x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
## How Has This Been Tested?
added tests to verify that previous failures no longer happen
## Checklist:
- [x ] My code follows the style guidelines of this project
- [ x] I have performed a self-review of my own code
- [ x] I have commented my code, particularly in hard-to-understand areas
- [ x] I have made corresponding changes to the documentation
- [ x] My changes generate no new warnings
- [ x] I have added tests that prove my fix is effective or that my feature works
- [ x] New and existing unit tests pass locally with my changes
- [ x] Any dependent changes have been merged and published in downstream modules
- [ x] I have checked my code and corrected any misspellings