Skip to content

XS✔ ◾ Markdown Link Check: Skipping Email Address#557

Merged
muiriswoulfe merged 2 commits intomainfrom
muiriswoulfe/fixing-markdown-link-check
Nov 15, 2024
Merged

XS✔ ◾ Markdown Link Check: Skipping Email Address#557
muiriswoulfe merged 2 commits intomainfrom
muiriswoulfe/fixing-markdown-link-check

Conversation

@muiriswoulfe
Copy link
Copy Markdown
Member

@muiriswoulfe muiriswoulfe commented Nov 11, 2024

Summary

This updates the .github/linters/markdown-link-check.json file to add a new exclusion pattern for mailto links. This ensures that the linter does not validate email addresses, where validation will now always fail.

Testing

Test Types

  • Unit tests
  • Manual tests

Unit Test Coverage

100%

@muiriswoulfe muiriswoulfe added the bug Something isn't working label Nov 11, 2024
@muiriswoulfe muiriswoulfe self-assigned this Nov 11, 2024
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner November 11, 2024 12:07
@github-actions
Copy link
Copy Markdown
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 3
Total 3

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Markdown Link Check: Skipping Email Address XS✔ ◾ Markdown Link Check: Skipping Email Address Nov 11, 2024
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) November 11, 2024 12:45
@muiriswoulfe muiriswoulfe merged commit dc61eb2 into main Nov 15, 2024
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/fixing-markdown-link-check branch November 15, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants