Harden TechJournalist media bootstrap per PR #537 review feedback#540
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Harden TechJournalist media bootstrap per PR #537 review feedback
May 13, 2026
leestott
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
This PR addresses all actionable comments in the linked PR #537 review thread for the Phi-4 TechJournalist notebook. The notebook’s media bootstrap path lacked bounded download/error handling, and image loading could retain an open file handle.
How did you fix it?
Media download reliability
Path("media")bootstrap and standardizedimage_path/audio_path.RuntimeErrorinstructing manual placement undermedia/.Resource handling for image input
Notebook wiring updates
urllib.requestandPathimports required by the new bootstrap logic.Testing
Scope is limited to the requested review-thread fixes in the notebook.