Skip to content

Jofinn/fix session id crash#24

Merged
maustinjones merged 3 commits intomicrosoft:masterfrom
jfinnecy:jofinn/FixSessionIdCrash
Jul 18, 2022
Merged

Jofinn/fix session id crash#24
maustinjones merged 3 commits intomicrosoft:masterfrom
jfinnecy:jofinn/FixSessionIdCrash

Conversation

@jfinnecy
Copy link
Copy Markdown
Contributor

@jfinnecy jfinnecy commented Jul 7, 2022

  1. Move the fetching of sessionId to disrupt a race condition where we get intermittent failures (exceptions) trying to access Core scripts.
  2. Wrap the fetch in try/catch so that even if it fails it will still execute tests, it just won't report sessionId. If we see a lot of reports of test results with no session Id's we can revisit to look for a better solution/placement of the code.

@jfinnecy
Copy link
Copy Markdown
Contributor Author

jfinnecy commented Jul 7, 2022

DOC modernization may eventually make this method of fetching sessionId invalid. We should consider adding SessionId to the test results in the future so we don't need to query for it separately.

@maustinjones maustinjones merged commit baa1846 into microsoft:master Jul 18, 2022
@jfinnecy jfinnecy deleted the jofinn/FixSessionIdCrash branch July 20, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants