Dev/mahartov/msal and enhancements#194
Merged
may-hartov merged 9 commits intomasterfrom Aug 30, 2022
Merged
Conversation
…tion samples Here we handle the case when we have cloud gateway. In case of cloud gateway, when we try to get the gateway information using `gatewayId`, the call throws a `404 Not Found` error. This error indicates the existence of cloud gateway. In case of on-premises gateway, we get a success response with information like `publicKey`(required for encryption). So here, we add try catch block to handle the `404` error and continue the flow with cloud gateway.
…t variables Related work items: #766862, #769896
…l to msal-react, update python requirements.txt 1. python encryption samples requirements.txt update 2. Migrating react samples from msal to @azure/msal-react References - https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-react/docs/class-components.md https://docs.microsoft.com/en-us/azure/active-directory/develop/tutorial-v2-react
…SAL authentication library instead of ADAL Upgrade NodeJS samples to use MSAL authentication library instead of ADAL 1. Master User Authentication  2. Service Principal Authentication  Related work items: #769133
ghost
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates to samples auth from ADAL -> MSAL + cloudConfig enhancements