EncryptGatewayCredentials#216
Merged
VsabGit merged 1 commit intomicrosoft:masterfrom May 18, 2023
Merged
Conversation
Script that creates a few functions to encrypt different types of credentials to use with the Power BI Gateway APIs
VsabGit
reviewed
Mar 20, 2023
| # 09/03/2023 | ||
| # | ||
| # **Notes** | ||
| # Script created based on the code here: |
Contributor
There was a problem hiding this comment.
I would write "based on the article here" instead
VsabGit
reviewed
Mar 20, 2023
| # https://endjin.com/blog/2020/12/how-to-update-credentials-for-an-on-prem-power-bi-data-source-using-powershell | ||
| # | ||
| # You will need to run this script at least once to validate the libraries are present in your system | ||
| # After this, you will only need to run the "CreateDatasource" script as it will load this in memory |
Contributor
There was a problem hiding this comment.
"CreateDatasource or UpdateGatewayDatasource" would be more accurate, right?
VsabGit
reviewed
Mar 20, 2023
Contributor
VsabGit
left a comment
VsabGit
left a comment
There was a problem hiding this comment.
I glanced over the code, but in general had implicit assumption, that the code itself didn't change since we tested it together.
I looked more on the wording and comments in the code.
| [string]$GatewayModulus | ||
| ) | ||
|
|
||
| # Create the objects to perform the necessary encryption on the credentials. Again, since I'm using basic credentials, I'm constructing a new BasicCredentials class. Other classes can be found here: https://github.com/microsoft/PowerBI-CSharp/tree/bf7cdf047a0218f7a8555fa7966445812a043955/sdk/PowerBI.Api/Extensions/Models/Credentials |
Contributor
There was a problem hiding this comment.
"For basic credentials we construct a new BasicCredentials class"...
| $credentialsEncryptor = [Microsoft.PowerBI.Api.Extensions.AsymmetricKeyEncryptor]::new($gatewayKeyObj) | ||
| $basicCreds = [Microsoft.PowerBI.Api.Models.Credentials.BasicCredentials]::new($username, $PasswordAsString) | ||
|
|
||
| # Construct the CredentialDetails object. The resulting "Credentials" property on this object will have been encrypted appropriately, ready for use in the request payload. |
Contributor
There was a problem hiding this comment.
"will be encrypted appropriately"
| [string]$GatewayModulus | ||
| ) | ||
|
|
||
| # Create the objects to perform the necessary encryption on the credentials. Again, since I'm using basic credentials, I'm constructing a new BasicCredentials class. Other classes can be found here: https://github.com/microsoft/PowerBI-CSharp/tree/bf7cdf047a0218f7a8555fa7966445812a043955/sdk/PowerBI.Api/Extensions/Models/Credentials |
Contributor
There was a problem hiding this comment.
Fix to say "windows credentials" and "WindowsCredentials", other than that same as comment above (line 64).
| $credentialsEncryptor = [Microsoft.PowerBI.Api.Extensions.AsymmetricKeyEncryptor]::new($gatewayKeyObj) | ||
| $WindowsCreds = [Microsoft.PowerBI.Api.Models.Credentials.WindowsCredentials]::new($username, $PasswordAsString) | ||
|
|
||
| # Construct the CredentialDetails object. The resulting "Credentials" property on this object will have been encrypted appropriately, ready for use in the request payload. |
Contributor
There was a problem hiding this comment.
same as comment in line 69.
| [string]$GatewayModulus | ||
| ) | ||
|
|
||
| # Create the objects to perform the necessary encryption on the credentials. Again, since I'm using basic credentials, I'm constructing a new BasicCredentials class. Other classes can be found here: https://github.com/microsoft/PowerBI-CSharp/tree/bf7cdf047a0218f7a8555fa7966445812a043955/sdk/PowerBI.Api/Extensions/Models/Credentials |
Contributor
There was a problem hiding this comment.
Fix to say "anonymous credentials" and "AnonymousCredentials", other than that same as comment above (line 64).
| $credentialsEncryptor = [Microsoft.PowerBI.Api.Extensions.AsymmetricKeyEncryptor]::new($gatewayKeyObj) | ||
| $AnonymousCreds = [Microsoft.PowerBI.Api.Models.Credentials.AnonymousCredentials]::new() | ||
|
|
||
| # Construct the CredentialDetails object. The resulting "Credentials" property on this object will have been encrypted appropriately, ready for use in the request payload. |
Contributor
There was a problem hiding this comment.
same as comment in line 69.
| [string]$GatewayModulus | ||
| ) | ||
|
|
||
| # Create the objects to perform the necessary encryption on the credentials. Again, since I'm using basic credentials, I'm constructing a new BasicCredentials class. Other classes can be found here: https://github.com/microsoft/PowerBI-CSharp/tree/bf7cdf047a0218f7a8555fa7966445812a043955/sdk/PowerBI.Api/Extensions/Models/Credentials |
Contributor
There was a problem hiding this comment.
Fix to say "OAuth credentials" and "OAuth2Credentials", other than that same as comment above (line 64).
| $credentialsEncryptor = [Microsoft.PowerBI.Api.Extensions.AsymmetricKeyEncryptor]::new($gatewayKeyObj) | ||
| $Oauth2Creds = [Microsoft.PowerBI.Api.Models.Credentials.OAuth2Credentials]::new($OauthToken) | ||
|
|
||
| # Construct the CredentialDetails object. The resulting "Credentials" property on this object will have been encrypted appropriately, ready for use in the request payload. |
Contributor
There was a problem hiding this comment.
same as comment in line 69.
| [string]$GatewayModulus | ||
| ) | ||
|
|
||
| # Create the objects to perform the necessary encryption on the credentials. Again, since I'm using basic credentials, I'm constructing a new BasicCredentials class. Other classes can be found here: https://github.com/microsoft/PowerBI-CSharp/tree/bf7cdf047a0218f7a8555fa7966445812a043955/sdk/PowerBI.Api/Extensions/Models/Credentials |
Contributor
There was a problem hiding this comment.
Fix to say "key credentials" and "KeyCredentials", other than that same as comment above (line 64).
| $credentialsEncryptor = [Microsoft.PowerBI.Api.Extensions.AsymmetricKeyEncryptor]::new($gatewayKeyObj) | ||
| $KeyCreds = [Microsoft.PowerBI.Api.Models.Credentials.KeyCredentials]::new($Key) | ||
|
|
||
| # Construct the CredentialDetails object. The resulting "Credentials" property on this object will have been encrypted appropriately, ready for use in the request payload. |
Contributor
There was a problem hiding this comment.
same as comment in line 69.
VsabGit
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script that creates a few functions to encrypt different types of credentials to use with the Power BI Gateway APIs