Revert "Simplify batch create scenarios"#5
Merged
tpellissier-msft merged 1 commit intomainfrom Sep 9, 2025
Merged
Conversation
zhaodongwang-msft
approved these changes
Sep 9, 2025
abelmilash-msft
pushed a commit
that referenced
this pull request
Apr 13, 2026
… validation - Fix .. note:: in records.create/update/upsert to mention concurrent dispatch when max_workers > 1, not just sequential chunking (comment #1) - Import _MAX_WORKERS in records.py and build the ValueError message from it so the text stays accurate if the cap changes (comment #2) - Add explicit ValueError in _dispatch_chunks for non-int or < 1 max_workers, with three new tests covering zero, negative, and non-int inputs (comments #4/#5) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4
We have another change coming in shortly that uses XMultiple for bulk create. I'll add a followup that brings in the prefix fix from this PR, which we want to keep.