Conversation
I don't understand how this used to work. I assume the library broke backwards compatibility at some point.
Something changed in Pester 5 and this is causing issues in CI.
For some reason, it looks like the NJsonSchema library exports a NJsonSchema object if queried from .NET Core, but if queried from .NET Framework (Windows PowerShell) it exports a NJsonSchema4 object. From the same DLL. This is a workaround to fallback to NJsonSchema4 if NJsonSchema doesn't seem available, which makes the library work for Windows PowerShell.
There is a 1/100 chance that a probability check with probability 0 would give the wrong result, because if the random number is 0 the old code would check if 0 > 0, which is of course false. Change the test to ≥ to account for this corner case. Fixes #18.
lupino3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.