Merged
Conversation
This will remove the dependency from external assemblies in PowerShell >- 6.1.0, and therefore increase compatibility by removing the possibility of assembly conflicts or assembly loading errors.
The error message differs between Test-Json and NJsonSchema, and its validation adds no value to the tests, as that invalid JSON is already tested in another test case.
The code would not work for 6.1.0, as it would try to import NJsonSchema and Newtonsoft.JSON.
Member
Author
|
The tests under CI (Windows Powershell 5.1.20348.643 and Powershell 7.2.5) pass.
The change looks good and I'm merging it. I'll see if there is an easy fix for 6.x (with x < 1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove the dependency from external assemblies in
PowerShell >= 6.1.0, and therefore increase compatibility by
removing the possibility of assembly conflicts or assembly loading
errors.