[PowerToys Run] Fix corrupt/outdated plugins load crash#12424
Merged
jaimecbernardo merged 2 commits intomicrosoft:masterfrom Jul 19, 2021
Merged
[PowerToys Run] Fix corrupt/outdated plugins load crash#12424jaimecbernardo merged 2 commits intomicrosoft:masterfrom
jaimecbernardo merged 2 commits intomicrosoft:masterfrom
Conversation
Don't load plugins which don't have the new IcoPathDark and IcoPathLight fields.
mykhailopylyp
approved these changes
Jul 19, 2021
Contributor
mykhailopylyp
left a comment
mykhailopylyp
left a comment
There was a problem hiding this comment.
LGTM! Tested by copying Calculator plugin from 0.29.3 into Plugins folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
The existence of outdated plugins that were not correctly uninstalled causes some run time errors due to not being able to load the types in the plugin's assembly.
What is include in the PR:
A check for the inability to load the types in the assembly, with an appropriate log error message.
Doesn't load plugins that don't contain the new plugin config format containing "IcoPathDark" and "IcoPathLight" fields.
Also adds the file location to the error messages for loading the plugins.
How does someone test / validate:
We've been unable to reproduce the error through normal means.
Copying the Calculator plugin from v0.29.3 to the PowerToys run plugin folder and trying to use PowerToys Run should be enough to verify this no longer crashes PowerToys.
Quality Checklist