Skip to content

fix: Start as Admin Error: Unable to open app when running elevated #2411

Merged
5 commits merged intodev/build-featuresfrom
user/lamotile/fix_runelevated_error
May 3, 2020
Merged

fix: Start as Admin Error: Unable to open app when running elevated #2411
5 commits merged intodev/build-featuresfrom
user/lamotile/fix_runelevated_error

Conversation

@ghost
Copy link

@ghost ghost commented Apr 27, 2020

Summary of the Pull Request

  • Added a fix for start as admin.
  • Settings configs for powerprev changed on the master branch, I applied related changes and added tests

References

PR Checklist

  • Applies to Start as Admin Error: Unable to open app when running elevated #2287
  • CLA signed. If not, go over here and sign the CLA
  • [] Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

  • Added tests and run the application to verify.

@ghost ghost linked an issue Apr 27, 2020 that may be closed by this pull request
@ghost ghost requested review from a team, crutkas and traies April 27, 2020 04:35
@arjunbalgovind
Copy link
Contributor

I tried this and found that on pressing Restart as admin, the runner doesn't crash and it works as expected. However if you close the settings window and try to open it again you still get the desktopsource xaml exception

@ghost
Copy link
Author

ghost commented Apr 28, 2020

I tried this and found that on pressing Restart as admin, the runner doesn't crash and it works as expected. However if you close the settings window and try to open it again you still get the desktopsource xaml exception

I fixed it here: 8c8ca53 can you verify if the fix works for on your side. Thanks

@ghost ghost added the Product-Settings The standalone PowerToys Settings application label Apr 30, 2020
@crutkas
Copy link
Member

crutkas commented May 1, 2020

@arjunbalgovind can you verify
@laviusmotileng-ms this now has a conflict

Copy link
Contributor

@arjunbalgovind arjunbalgovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified that it works on my machine

Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. In the future these should be two or 3 separate PRs though please :).

@ghost ghost force-pushed the user/lamotile/fix_runelevated_error branch from 8f38691 to 8c8ca53 Compare May 3, 2020 09:44
@ghost ghost merged commit b428fc9 into dev/build-features May 3, 2020
@ghost ghost deleted the user/lamotile/fix_runelevated_error branch May 3, 2020 10:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Settings The standalone PowerToys Settings application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start as Admin Error: Unable to open app when running elevated

4 participants