[FancyZones] Make snapping windows using Windows Snap Hotkeys across monitors optional

[stefansjfw]

Summary of the Pull Request

New toggle is added into FancyZones settings to enable/disable snapping windows to zones across monitors when moving windows using Windows Snap Hotkeys.

References

PR Checklist

• [] Applies to [FancyZones] win+left/right over multiple monitors should be optional #2319
• [] CLA signed. If not, go over here and sign the CLA
• [] Tests added/passed
• [] Requires documentation to be updated
• [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Manually tested for correct functionality and regressions on single and multi-monitor environment.

[enricogior]

We need to add the new setting to telemetry

PowerToys/src/modules/fancyzones/lib/trace.cpp

Lines 170 to 190 in 64df515

	TraceLoggingWrite(
	g_hProvider,
	"FancyZones_SettingsChanged",
	ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
	TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
	TraceLoggingBoolean(settings.shiftDrag, "ShiftDrag"),
	TraceLoggingBoolean(settings.displayChange_moveWindows, "MoveWindowsOnDisplayChange"),
	TraceLoggingBoolean(settings.virtualDesktopChange_moveWindows, "MoveWindowsOnVirtualDesktopChange"),
	TraceLoggingBoolean(settings.zoneSetChange_flashZones, "FlashZonesOnZoneSetChange"),
	TraceLoggingBoolean(settings.zoneSetChange_moveWindows, "MoveWindowsOnZoneSetChange"),
	TraceLoggingBoolean(settings.overrideSnapHotkeys, "OverrideSnapHotKeys"),
	TraceLoggingBoolean(settings.appLastZone_moveWindows, "MoveWindowsToLastZoneOnAppOpening"),
	TraceLoggingBoolean(settings.use_cursorpos_editor_startupscreen, "UseCursorPosOnEditorStartup"),
	TraceLoggingBoolean(settings.showZonesOnAllMonitors, "ShowZonesOnAllMonitors"),
	TraceLoggingBoolean(settings.makeDraggedWindowTransparent, "MakeDraggedWindowTransparent"),
	TraceLoggingWideString(settings.zoneColor.c_str(), "ZoneColor"),
	TraceLoggingWideString(settings.zoneBorderColor.c_str(), "ZoneBorderColor"),
	TraceLoggingWideString(settings.zoneHightlightColor.c_str(), "ZoneHighlightColor"),
	TraceLoggingInt32(settings.zoneHighlightOpacity, "ZoneHighlightOpacity"),
	TraceLoggingWideString(hotkeyStr.c_str(), "Hotkey"),
	TraceLoggingInt32(static_cast<int>(settings.excludedAppsArray.size()), "ExcludedAppsCount"));

[stefansjfw]

We need to add the new setting to telemetry

PowerToys/src/modules/fancyzones/lib/trace.cpp

Lines 170 to 190 in 64df515

	TraceLoggingWrite(
	g_hProvider,
	"FancyZones_SettingsChanged",
	ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
	TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
	TraceLoggingBoolean(settings.shiftDrag, "ShiftDrag"),
	TraceLoggingBoolean(settings.displayChange_moveWindows, "MoveWindowsOnDisplayChange"),
	TraceLoggingBoolean(settings.virtualDesktopChange_moveWindows, "MoveWindowsOnVirtualDesktopChange"),
	TraceLoggingBoolean(settings.zoneSetChange_flashZones, "FlashZonesOnZoneSetChange"),
	TraceLoggingBoolean(settings.zoneSetChange_moveWindows, "MoveWindowsOnZoneSetChange"),
	TraceLoggingBoolean(settings.overrideSnapHotkeys, "OverrideSnapHotKeys"),
	TraceLoggingBoolean(settings.appLastZone_moveWindows, "MoveWindowsToLastZoneOnAppOpening"),
	TraceLoggingBoolean(settings.use_cursorpos_editor_startupscreen, "UseCursorPosOnEditorStartup"),
	TraceLoggingBoolean(settings.showZonesOnAllMonitors, "ShowZonesOnAllMonitors"),
	TraceLoggingBoolean(settings.makeDraggedWindowTransparent, "MakeDraggedWindowTransparent"),
	TraceLoggingWideString(settings.zoneColor.c_str(), "ZoneColor"),
	TraceLoggingWideString(settings.zoneBorderColor.c_str(), "ZoneBorderColor"),
	TraceLoggingWideString(settings.zoneHightlightColor.c_str(), "ZoneHighlightColor"),
	TraceLoggingInt32(settings.zoneHighlightOpacity, "ZoneHighlightOpacity"),
	TraceLoggingWideString(hotkeyStr.c_str(), "Hotkey"),
	TraceLoggingInt32(static_cast<int>(settings.excludedAppsArray.size()), "ExcludedAppsCount"));

@enricogior It's in the PR already

[enricogior]

This may need more explanation: "Move windows between zones across monitors"

"Move windows between zones across all monitors when snapping with win+arrow"

[stefansjfw]

I agree that this one in PR is not the best one :) I'm open for proposals. It's way more clear how you decribed it

[stefansjfw]

Done.

[enricogior]

Tested on single monitor, dual monitor and triple monitor configuration. Works es expected.

[vldmr11080]

Tested on dual monitor configuration. Works as expected.