Skip to content

updating read me file with date and time #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furahadamien merged 2 commits into from
May 6, 2020
Merged

updating read me file with date and time #2722

furahadamien merged 2 commits into from
May 6, 2020

Conversation

@furahadamien
Copy link

@furahadamien furahadamien commented May 6, 2020

Summary of the Pull Request

Created doc/interns/furahadamien/MyFirstCommit.md

References

PR Checklist

  • [] Applies to #xxx
  • [] CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@furahadamien furahadamien requested a review from letitiakwan May 6, 2020 15:18
markAtMicrosoft
markAtMicrosoft suggested changes May 6, 2020
View reviewed changes
doc/Interns/furahadamien/MyFirstCommit.md Outdated
@@ -0,0 +1 @@
05/06/2020 No newline at end of file
Copy link

@markAtMicrosoft markAtMicrosoft May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention in the instructions. Please add Time to this time... Date and Time is what we are looking for.

Copy link
Author

@furahadamien furahadamien May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will work on that

@crutkas
Copy link
Member

crutkas commented May 6, 2020

Can we update the title of the PR?

crutkas
crutkas previously approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@crutkas crutkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@markAtMicrosoft markAtMicrosoft requested a review from crutkas May 6, 2020 15:51
@crutkas crutkas dismissed their stale review May 6, 2020 15:51

dismissing my review.

@furahadamien
Copy link
Author

furahadamien commented May 6, 2020

Can we update the title of the PR?

will work on it

@furahadamien furahadamien changed the title updating my file. MyFirstPR May 6, 2020
letitiakwan
letitiakwan approved these changes May 6, 2020
View reviewed changes
Copy link

@letitiakwan letitiakwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@furahadamien furahadamien merged commit ab9ad1e into interns/dev-oobe May 6, 2020
@furahadamien furahadamien changed the title MyFirstPR updating read me file with date and time May 6, 2020
@furahadamien furahadamien deleted the interns/users/t-fudami/dev-oobe branch May 6, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crutkas crutkas Awaiting requested review from crutkas

2 more reviewers

@letitiakwan letitiakwan letitiakwan approved these changes

@markAtMicrosoft markAtMicrosoft markAtMicrosoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@furahadamien @crutkas @letitiakwan @markAtMicrosoft